Re: [PATCH v2 1/3] iptables: change 'iface' part in hash:net,iface set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



OK, that's good because I intend to change the parse_dirs function in the new "version" and introduce additional parameter called "features" so that these are used directly and not rely on the info->flags to store these (as was the case up until now). That would also allow for additional features to be added in the future, if needed (u8 is almost exhausted - you have one spare bit left there!).

The almost exhausted u8 is an additional reason why it's better to use unsigned int in the *protocol* between the kernel-userspace (struct ip_set_req_get_features).
Yeah, I got it Jozsef - I'll alter ip_set_req_get_features to use unsigned in instead of u8. Jesus!

Are you happy for the extra parameter called "features" to be included in the print function (iptables - userspace) as this is where I will store the features, not by using info->flags anymore?

Yep, just saw that too, so I'll just move the ip_set_feature enum just above the #ifdef __KERNEL__ part and I assume it would be picked up "automatically", is that right?

No, let the patchset be complete in itself, i.e. include the patches both for the kernel and iptables header files.
Fair enough.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux