On Fri, 13 Jul 2012, Mr Dash Four wrote: > > These functions are static. Nothing else uses them. > > > OK, that's good because I intend to change the parse_dirs function in > the new "version" and introduce additional parameter called "features" > so that these are used directly and not rely on the info->flags to store > these (as was the case up until now). That would also allow for > additional features to be added in the future, if needed (u8 is almost > exhausted - you have one spare bit left there!). The almost exhausted u8 is an additional reason why it's better to use unsigned int in the *protocol* between the kernel-userspace (struct ip_set_req_get_features). > > At the moment, the enum ip_set_feature definition is kernel specific > > in the kernel header file. Next time Pablo regenerates the header > > files for iptables from the kernel ones, your modification above will > > be lost. Therefore the enum definition must be moved out from the > > "#ifdef __KERNEL__" region in the kernel header file. > > > Yep, just saw that too, so I'll just move the ip_set_feature enum just > above the #ifdef __KERNEL__ part and I assume it would be picked up > "automatically", is that right? No, let the patchset be complete in itself, i.e. include the patches both for the kernel and iptables header files. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlecsik.jozsef@xxxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : Wigner Research Centre for Physics, Hungarian Academy of Sciences H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
