On Monday 14 May 2012 17:24:39 Eric Dumazet wrote: > On Mon, 2012-05-14 at 17:05 +0200, Jan Engelhardt wrote: > > On Monday 2012-05-14 16:40, Pablo Neira Ayuso wrote: > > > > >> - if (t->uports.p16.dst < t->uports.p16.src) > > >> + if (ntohs(t->uports.p16.dst) < ntohs(t->uports.p16.src)) > > > > > >Do we really need this to make sparse happy? > > > > You need it to make *maths* happy. > > > > Consider > > > > 384 < 65407 > > > > but > > > > ntohs(384) > ntohs(65407) > > <=> 32769 > 32767 > > -- > > Doesnt matter at all in this context. This context can contain both le & be machines, so at least in hmark it make sense > Take a look at > > void __skb_get_rxhash(struct sk_buff *skb) > > if ((__force u16)keys.port16[1] < (__force u16)keys.port16[0]) > swap(...) > > -- Regards Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
