On Monday 2012-05-14 16:40, Pablo Neira Ayuso wrote: >> - if (t->uports.p16.dst < t->uports.p16.src) >> + if (ntohs(t->uports.p16.dst) < ntohs(t->uports.p16.src)) > >Do we really need this to make sparse happy? You need it to make *maths* happy. Consider 384 < 65407 but ntohs(384) > ntohs(65407) <=> 32769 > 32767 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html