On Mon, 2011-06-06 at 21:15 -0700, Maciej Åenczykowski wrote: > I'm still opposed on the grounds that there may be people relying on > the current behaviour. That is not my call, but I can tell you that I wrote this patch in response to a report from several carriers that were complaining that Linux' mangling code was completely broken and unusable. >From my experience, we are in a situation where people used to IPv4's mangling code are starting to migrate to IPv6 only to find out that some of their iptables rules do not work as expected, the reason (unknown to them) being that IPv6's DSCP mangling code was not implemented according to the documentation. I would think that the benefit of fixing this outweighs the risk of breaking some systems relying on the current behavior, which is the opposite of what the documentation says and what its IPv4 counterpart does. > This should not make it into the stable series of kernels. > I can understand fixing it for a future upstream release. At the very least, [PATCH 1/2] netfilter: IPv6: initialize TOS field in REJECT target module is needed (of course, I would like to have 2/2 patch applied too). Without this patch the TOS field of IPv6 packets generated by the REJECT target module is random. - Fernando -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
