Re: [PATCH 2/2] netfilter: IPv6: fix DSCP mangle code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> The mask indicates the bits one wants to zero out, so it needs to be
> inverted before applying to the original TOS field.

Uhm, does it?
This is backwards incompatible...

To me, you always 'and' with a mask, not with the negation of the mask.
ie. a mask is the bits you want to keep.

(mind you I haven't looked at the documentation of the feature, but
I'm still pretty sure the right fix here is to change the docs, not
the functionality)

> The following Linux kernels are affected: <= 2.6.38.8

- Maciej
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux