Hi Holger, On Wed, 19 Jan 2011, holger@xxxxxxxxxxxxxxxx wrote: > what follows are two small patches which remove unneeded argv[] > loops when parsing the ipset commands. They are in particular no > change in command line handling. > > The command line handling can still be improved, as e. g. > > $ ipset -o xml create foo hash:ip > $ ipset -s add foo 192.168.1.1 > > both work, but the options are just ignored. And they don't > make much sense for either 'create' or 'add'. > > Also we should consider to make the argument handling a little > more strict, as e. g. > > $ ipset -o xml list foo > $ ipset list -o xml foo > $ ipset list foo -o xml > > all work. By removing some of those possibilities it should even > get simpler code wise. Thank you indeed, after fixing the issues raised by Patrick and Eric, I'll work on the userspace part and your patches. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
