On Wed, 19 Jan 2011, Eric Dumazet wrote: > Le samedi 15 janvier 2011 ? 00:23 +0100, Jozsef Kadlecsik a ?crit : > > > +/* Allocate members */ > > +static inline void * > > +ip_set_alloc(size_t size, gfp_t gfp_mask) > > +{ > > + void *members = NULL; > > + > > + if (size < KMALLOC_MAX_SIZE) > > + members = kzalloc(size, gfp_mask | __GFP_NOWARN); > > + > > + if (members) { > > + pr_debug("%p: allocated with kmalloc", members); > > + return members; > > + } > > + > > + members = __vmalloc(size, gfp_mask | __GFP_ZERO, PAGE_KERNEL); > > + if (!members) > > + return NULL; > > + pr_debug("%p: allocated with vmalloc", members); > > + > > + return members; > > +} > > + > > Note : We now have vzalloc(), no need to use __vmalloc() (BTW > __GFP_HIGHMEM is missing) Thanks Eric, I'll use vzalloc and add the missing flag. Best regards, Jozsef - E-mail : kadlec@xxxxxxxxxxxxxxxxx, kadlec@xxxxxxxxxxxx PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt Address : KFKI Research Institute for Particle and Nuclear Physics H-1525 Budapest 114, POB. 49, Hungary -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html