On 16.12.2010 01:27, Jan Engelhardt wrote: > > On Wednesday 2010-12-15 23:47, Patrick McHardy wrote: >>>> >>>> I'll also gladly apply a patch to get rid of the u_int_XX crap. >>> >>> To be found where? (Choose: kernel/userspace/both) >> >> Both I guess, but I was previously referring to the kernel. > > I do not see the issue with using POSIX types outside of operating > system interface specifications. > So I guess this is in order: > > parent 3a84b3d5de492e40aff7bae5038b06dd6b6041c4 (v1.4.10-17-g3a84b3d) > commit a069355b7933c9afe38b5cb7b251b2ece4fe8456 > Author: Jan Engelhardt <jengelh@xxxxxxxxxx> > Date: Thu Dec 16 00:59:27 2010 +0100 > > src: use C99/POSIX types > > "u_int" was a non-standardized extension predating C99 on some platforms. While I don't have a real personal preference, most of the remaining networking stack uses uXX types and I know code has been actively converted from C99 types to those. So for consistency we should also use uXX. Sorry for not being clearer about that before. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html