On Fri, 26 Nov 2010 13:51:01 -0800 Stephen Hemminger <shemminger@xxxxxxxxxx> wrote: > The netlink interface to dump the connection tracking table has a race > when entries are deleted at the same time. A customer reported a crash > and the backtrace showed thatctnetlink_dump_table was running while a > conntrack entry wasbeing destroyed. > (see https://bugzilla.vyatta.com/show_bug.cgi?id=6402). > > According to RCU documentation, when using hlist_nulls the reader > must handle the case of seeing a deleted entry and not proceed > further down the linked list. The old code would continue > which caused the scan to walk into the free list. > > This patch uses locking (rather than RCU) for this operation which > is guaranteed safe, and no longer requires getting reference while > doing dump operation. > > Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxx> This should go in net-2.6 and stable for 2.6.32, 2.6.35, and 2.6.36 -- -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
