Apart from my comments below, the userspace patch looks ok: - I would line up the help and man page entries between arptables and iptables so noone gets confused. Also, the man page entry refers to set-class-mac. - In final_check() you should make sure that the priority has been set (similar to what's done in libxt_CLASSIFY.c). cheers, Bart On 13-11-10 16:29, Frederic Leroy wrote: > Le Fri, 12 Nov 2010 08:49:59 +0100, > Patrick McHardy <kaber@xxxxxxxxx> a écrit : > >> On 11.11.2010 12:45, Frederic Leroy wrote: >>> Le Thu, 11 Nov 2010 11:38:41 +0100, >>> Patrick McHardy <kaber@xxxxxxxxx> a écrit : >> You can't change the numerical values, that would break compatibility. >> That basically leaves the option of using NF_INET_PRE_ROUTING instead >> of NF_ARP_IN etc, which would make things highly confusing :) > There is no much use of NF_ARP_* in the google codesearch world, but I > understand the need to not break compatibility. > > So I joined my last patches to xt_CLASSIFY and arptables. > > I checked that : > - modules are autoloaded > - it works as intended for marking cos on vlan interface. > -- Bart De Schuymer www.artinalgorithms.be -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
