Jan Engelhardt wrote: > On Friday 2010-05-14 02:38, Jason Gunthorpe wrote: > >> At least the XEN net front driver always produces non linear skbs, >> so the SIP module does nothing at all when used with that NIC. >> >> Copy the hacky technique for accessing SKB data from the ftp conntrack, >> better than nothing.. >> >> Signed-off-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> >> >> +/* This is slow, but it's simple. --RR */ >> +static char *sip_buffer; >> +static DEFINE_SPINLOCK(nf_sip_lock); >> + > > skb_linearize seems simpler. (What about the cost?) Yeah, we have to use skb_linearize(). The SIP NAT helper might mangle the packet and alter its size, at which point we'd have to make a new copy of the data area to get the offsets right. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
