Re: [PATCH 11/11] netfilter: xtables: convert basic nfproto match functions into xt matches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2010-05-11 14:59, Patrick McHardy wrote:

>Jan Engelhardt wrote:
>> Each table implementation has a private built-in hardwired match
>> function for its corresponding nfproto data (e.g. ip_tables: struct
>> ipt6_ip6 processed by ip6_packet_match to match against the IPv6
>> header, etc.)
>> 
>> Rewrite the functions so that they are independent xt_matches and can
>> be used from an nfproto-independent table.
>
>No major objections, but I'd like to know where this is going
>and when, so far this doesn't provide any benefit.

The plan, as posted last fall[1], is to continue generalizing the 
different iptables copies into one, bringing Xtables up to the next 
level, e.g. family-agnostic rulesets, while retaining 
compatibility.

[1] http://lwn.net/Articles/345176/

The "when" originally was 2.6.32, but I got a little slacky in doing 
requested benchmarks, so it had practically postponed itself to the 
current cycle, 2.6.35. If my counting is right, ~41 patches of that 
list[1] have been merged, and while doing that, 46 concurrent 
commits/ideas of mine have also been merged.

There are at least 60 patches left however, and that does not include 
any comments from your side. I guess I don't get to spool and flush the 
entire queue to 2.6.35 anymore - "better luck next time", or?

>And as always, please format things like
>
>> +	ret = ifname_compare_aligned((par->in == NULL) ? nulldevname :
>> +	      par->in->name, ipinfo->iniface, ipinfo->iniface_mask);
>
>so the arguments are neatly aligned. F.i.
>
>	ret = ifname_compare_aligned(!par->in ? nulldevname : par->in->name,
>				     ipinfo->iniface, ipinfo->iniface_mask);
>
>would work nicely.
>

Will revisit.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux