Jan Engelhardt wrote: > Each table implementation has a private built-in hardwired match > function for its corresponding nfproto data (e.g. ip_tables: struct > ipt6_ip6 processed by ip6_packet_match to match against the IPv6 > header, etc.) > > Rewrite the functions so that they are independent xt_matches and can > be used from an nfproto-independent table. No major objections, but I'd like to know where this is going and when, so far this doesn't provide any benefit. And as always, please format things like > + ret = ifname_compare_aligned((par->in == NULL) ? nulldevname : > + par->in->name, ipinfo->iniface, ipinfo->iniface_mask); so the arguments are neatly aligned. F.i. ret = ifname_compare_aligned(!par->in ? nulldevname : par->in->name, ipinfo->iniface, ipinfo->iniface_mask); would work nicely. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
