Jan Engelhardt wrote: > On Wednesday 2010-04-21 15:39, Patrick McHardy wrote: >> Jan Engelhardt wrote: >>> xt_condition can be used by userspace to influence decisions in rules >>> by means of togglable variables without having to reload the entire >>> ruleset. >>> + >>> + var->refcount = 1; >>> + var->enabled = false; >>> + var->status_proc->data = var; >>> + wmb(); >> Jan, while I'm pretty patient, I don't appreciate having to repeat >> the same thing multiple times: >> >>>> Please always comment the use of memory barriers. > > I am sorry I missed that; it seemed clear within the first 10 lines > of your mail (which just quoted the patch) that I sent out the > rcu-bugged variant and skipped the rest. > > My share on the topic of patience - let me express that merges seemed > to be processed faster in the rc1 week once a good-looking series was > posted. As for maintenance, I think there should also be less > turnarounds/resends. No doubt that tires out maintainers and > bystanders alike looking at the same patch again and again. That's not a big problem, I'd rather have a few more resends than merge something buggy. I mainly would like submitters to be careful about their patches. I usually review my own work multiple times before sending it out since I know how easily something stupid can slip in. Lets leave it at that :) > Adding > routing-by-oif could have easily be added as a patch on top, given it > was a feature not a bugfix. Yeah, it was a bigger change than I anticipated. > (N.B.: Where did iptables.git/extensions/libxt_TEE.c go? You asked for > it, but it did not show up yet either.) I used it for testing. As usual, it will be merged once the release for the next kernel version is out. I don't want to go back to release userspace parts for things which are not included in mainline yet. That has bit us multiple times when we had to change the ABI. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
