Jan Engelhardt wrote:
> xt_condition can be used by userspace to influence decisions in rules
> by means of togglable variables without having to reload the entire
> ruleset.
> +
> + var->refcount = 1;
> + var->enabled = false;
> + var->status_proc->data = var;
> + wmb();
Jan, while I'm pretty patient, I don't appreciate having to repeat
the same thing multiple times:
>> Please always comment the use of memory barriers.
> +static int __net_init condnet_mt_init(struct net *net)
> +{
> + int ret;
> +
> + proc_net_condition = proc_mkdir(dir_name, net->proc_net);
> + if (proc_net_condition == NULL)
> + return -EACCES;
> +
> + ret = xt_register_match(&condition_mt_reg);
This is really starting to annoy me. Please read what I wrote,
take your time, test the patch and then resend it.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
