Jan Engelhardt wrote: > On Tuesday 2010-04-13 12:51, Patrick McHardy wrote: >>>>> +/* Allow this many total (re)entries. */ >>>>> +static unsigned int xt_jumpstack_multiplier = 2; >>>>> +module_param_named(jumpstack_multiplier, xt_jumpstack_multiplier, >>>>> + uint, S_IRUGO | S_IWUSR); >>>>> + >>>> This seems very wrong. Why should the user care about this? >>> Who said every sysfs variable is for end-users? >> Then who should care? > > Developers, perhaps. Not exporting the parameter is no big deal. Developers can change it in the source code. Please remove the parameter and hard code it. I'll then apply this patch if we can get rid of the ruleset duplication for each CPU. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
