Re: [PATCH 5/6] netfilter: xt_TEE: have cloned packet travel through Xtables too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> On Tuesday 2010-04-13 12:00, Patrick McHardy wrote:
>> Jan Engelhardt wrote:
>>> --- a/net/netfilter/xt_TEE.c
>>> +++ b/net/netfilter/xt_TEE.c
>>> @@ -33,6 +33,7 @@ static struct nf_conn tee_track;
>>>  #endif
>>>  
>>>  static const union nf_inet_addr tee_zero_address;
>>> +static bool tee_active[NR_CPUS];
>> DEFINE_PER_CPU?
> 
> I asked about that. It seems like percpu.h puts the variable in an extra 
> section and with pretty much #define magic around it (e.g. look at the 
> #definition of percpu_set) all of which did not seem necessary to me.
> 

It should avoid having a huge array that bounces between CPUs
since their entries are located next to each other.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux