Re: input-layer LEDs as LED-class devices (was: Add refcounts to LED target)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 2010-04-08 05:15, Adam Nielsen wrote:
>
>> And what I observed is that I get duplicated keypresses when there is
>> network activity. (UP with CONFIG_PREEMPT=y.) Most likely because the
>> i8042 keyboard is such a piece of legacy hardware that it is not
>> worth investigating. I don't have any USB keyboard handy right now,
>> so testing that needs to wait until after the holidays.
>
>Did you try it with the iptables --led-delay option?

Yes.

I would assume that the key repeat happens whenever the LED is
changed *and* I happen to press a key at the same time. This event
happening is IMO independent of the led-delay option, as the LED
state could change either by a delay-induced LED_OFF, or by a new
packet arriving.

> I've only tried it with
>USB keyboards but that seems to be required for it to work smoothly
>(--led-delay 1 is fine.)  Perhaps a higher delay value is needed for i8042
>keyboards?
>
>I'm wondering whether I should implement the delay in the module
>itself so that the user doesn't have to worry about it, it just
>becomes a "slow" LED device.

As long as you don't sleep in interrupt context ;-)

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux