Re: [PATCH 2/9] netfilter: xtables: slightly more detailed checkentry return values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
> On Wednesday 2010-03-17 15:40, Patrick McHardy wrote:
>>> OK that seems mostly fine. Basically its just the NULL/ENOENT
>>> interpretation that might be confusing.
>> One more thing though - I really don't like the strange mix of booleans
>> and errno codes. If you want to change this,
> 
> I'm pretty indifferent, but what if I don't want to change it? :-)

s/If/When/ :)

> Is it so bad to keep EINVAL and unspecified-error separated at the extension
> level?

It diverges from the well established return conventions in the kernel
for no reason. That's inviting bugs.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux