On Tuesday 2010-03-16 14:16, Bart De Schuymer wrote: >> >> from my side two build patches for arptables. >> >> (1) Do not call install with -o or -g, because it makes unprivileged >> installs (used by build chroots) fail. Autotools does not use -o or -g >> either, so the usage is consistent and does what was inteded when root >> is running `make install`. >> >> (2) Fixing all the compiler warnings that turned up about printf >> formatting and strict-aliasing. > >Someone once insisted using this -o -g usage long ago and no >distributors have complained about it yet, Fedora ships arptables_jf, which does not use -o,-g, thus does not have a problem to report. OpenSUSE shipped arptables_jf. I moved it back to arptables because the jf fork is in an uncertain state. Debian either builds with root or has patched install(1). >so I'm going to leave it in >for now. Plenty of other projects do it this way too. Well it is wrong, and I can list many more projects (namely: everything using automake's built-in installation) that do it the right way instead. If you are still not convinced: running automake's `make install` as root will (which you will have to do to even be eligible to install it to system locations), surprise surprise, install the files as root. So it's doing the right thing in both cases. >The warings that occur when using llu with 64-bit numbers should be >resolved with the PRIu64 macro. Could you fix that and resubmit, please? >Thanks. Hmm, iptables is not using PRI either so it seemed like the preferred approach. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
