On Tuesday 2010-03-16 11:31, Bart De Schuymer wrote: >> >> 1. ebtables-v2.0.9-2-LDFLAGS.diff - respect LDFLAGS during ebtables >> build. >> 2. ebtables-v2.0.8-2-ethertype-DESTDIR-mkdir.patch - create directories >> to avoid build failure when DESTDIR is supplied. > >Thanks for the patches. I have some questions, though. >- In what situation is LDFLAGS needed (it's not defined in the >Makefiles)? Is it standard practice to include this? LDFLAGS=-m32 and LDFLAGS=-Wl,--as-needed are two examples for this decade. >- Not all distros use the sysvinit package anymore (e.g. Ubuntu uses >upstart). In arptables I made the copying to INITDIR and SYSCONFIGDIR >dependent on the existence of the directories. That way we don't copy >the sysvinit type of files on a system that uses something else. I'd >prefer to do the same thing with ebtables. Does that sound ok to you? That sounds wrong to me. Chroots building software may have fewer directories than the Makefiles expect, so it's best not to install too few files. Deleting files in buildscripts is easier on the mind than postinstalling them. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
