On Fri, 2010-02-05 at 12:22 +0100, Patrick McHardy wrote: > Alexey Dobriyan wrote: > > On Fri, Feb 5, 2010 at 1:16 PM, Patrick McHardy <kaber@xxxxxxxxx> wrote: > >> OK testing looks fine, although I'm quite surprised that its actually > >> possible to change module parameters from within non-init namespaces. > >> How is this supposed to work at all? I don't see how sysfs could > >> possibly provide a network namespace context ... > > > > > > You can do in write hook > > > > if (!net_eq(current->nsproxy->net_ns, &init_net)) > > return -EINVAL; > > Right, I see. So we could actually make resizing work for all > namespaces quite easily. Is there any reason not to do this? Yes, but I think (2.6.34) there also needs to be a better way to expose netns topology and visualize all the hashtables on a system - if you're the admin you really want to be able to see all of them, not just for a particular namespace you might be in, in addition to the perns views. We already discussed 2.6.34, I'm only mentioning this "for the record". Jon. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
