Patrick McHardy wrote: > Alexey Dobriyan wrote: >>> How about this (so far untested) patch? The htable_size is moved into >>> the per-namespace struct and initialized from the current (global) >>> value of nf_conntrack_htable_size. Changes through sysfs are still >>> permitted, but only affect the init namespace and newly created ones. >> No matter what we do, it's a hack! >> >>> Additionally I removed reinitializing the hash random value when >>> changing the hash size since that also requires to rehash in all >>> namespaces. >> I'm not fond of this, because we're not even closely going to allow changing >> hashtable size per-netns. As such having actual per-netns hashtable size >> just slows down everything. > > Actually it doesn't seem like much more work to allow changing > table size, the main problem is that sysfs module parameters > don't seem to fit into the network namespace model at all. > > Please be more specific about your suspected slowdowns. > What's "everything"? What's different about the hashsize > compared to the many members we already moved to per-netns > structs? OK testing looks fine, although I'm quite surprised that its actually possible to change module parameters from within non-init namespaces. How is this supposed to work at all? I don't see how sysfs could possibly provide a network namespace context ... -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
