Hi,
On Fri, 2009-12-18 at 19:41 -0800, David Miller wrote:
> From: Evan McNabb <emcnabb@xxxxxxxxxx>
> Date: Fri, 18 Dec 2009 11:24:40 -0500
>
> > From: Evan McNabb <emcnabb@xxxxxxxxxx>
> >
> > Include exit function so nf_tproxy_core module can be removed.
> >
> > Signed-off-by: Evan McNabb <emcnabb@xxxxxxxxxx>
>
> netfilter-devel is the best place to CC: netfilter
> patches, added...
>
> >
> > diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> > index 5490fc3..ec6737c 100644
> > --- a/net/netfilter/nf_tproxy_core.c
> > +++ b/net/netfilter/nf_tproxy_core.c
> > @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> > return 0;
> > }
> >
> > +static void __exit nf_tproxy_exit(void)
> > +{
> > +}
> > +
> > module_init(nf_tproxy_init);
> > +module_exit(nf_tproxy_exit);
> >
> > MODULE_LICENSE("GPL");
> > MODULE_AUTHOR("Krisztian Kovacs");
I'm afraid it's not that simple...
tproxy sets skb->destructor to nf_tproxy_destructor for certain
(redirected) skbs. You must make sure that no skbs have their destructor
set to that function before removing the module.
Cheers,
Krisztian
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
