On Thursday 2009-10-01 02:50, Joe Perches wrote: >On Thu, 2009-10-01 at 02:31 +0200, Jan Engelhardt wrote: >> Well I personally prefer the #include instead of hiding such in >> Makefiles. You know, when newcomers could start doing `grep >> KMSG_COMPONENT *.[ch]`. Perhaps GCC's -include flag in a Makefile >> to avoid #includes in .c files? > >I imagine an eventual goal of standardizing the default >pr_fmt define in kernel.h to > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > >so that all pr_<level> calls get this unless otherwise >specified. I like that approach. Saves me adding that line to .c files repeatedly. >Or perhaps better, to get rid of pr_fmt(fmt) altogether and >have printk emit the filename/modulename, function and/or >code offset by using something like %pS after the level. I object to that. You would be spamming the dmesg ring buffer with all that info, plus filename: you would have to keep filename strings in the kernel. Surely I do not find that thrilling when there are ~18000 non-arch .[ch] files whose pathnames amount to 542K. Same goes similar for functions. modulename: obj-y files would only get "<built-in>" or something for KBUILD_MODNAME. Printing that to dmesg is not too useful. I would rather keep plain printk as-is. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
