On Thursday 2009-10-01 00:37, Joe Perches wrote: >This centralizes the definition and removes the >replicated #defines from all files And increases the length of the command line. Not that Linux does not support long command lines (in fact, configure often determines huge possible values on the max length test), but sometimes, developers have to inspect the command lines anyway for bugs, or something. It is already pretty long due to all the compiler flags. Oh what were the days of DOS programs that allowed to pass in arguments in a so-called "response file", wish we had that in gcc. >+ccflags-y += -D "KMSG_COMPONENT=\"IPVS\"" >+ccflags-y += -D "pr_fmt(fmt)=KMSG_COMPONENT \": \" fmt" >+ > # IPVS transport protocol load balancing support > ip_vs_proto-objs-y := > ip_vs_proto-objs-$(CONFIG_IP_VS_PROTO_TCP) += ip_vs_proto_tcp.o >diff --git a/net/netfilter/ipvs/ip_vs_app.c b/net/netfilter/ipvs/ip_vs_app.c >index 3c7e427..a5283d8 100644 >--- a/net/netfilter/ipvs/ip_vs_app.c >+++ b/net/netfilter/ipvs/ip_vs_app.c >@@ -18,9 +18,6 @@ > * > */ > >-#define KMSG_COMPONENT "IPVS" >-#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt How about an #include file for the ipvs private things? -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
