Re: [PATCH 2/2] netfilter: conntrack: optional reliable conntrack event delivery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick McHardy wrote:
Jozsef Kadlecsik wrote:
On Wed, 10 Jun 2009, Patrick McHardy wrote:

This is a first attempt to replace some global locks by private
per conntrack locks. On 64 bit, it fits into a hole and doesn't
enlarge struct nf_conn.
[...]
Now is that really better - I'm not sure myself :) The per-conntrack
locking would be an improvement though. What do you think?

I think it's cool and highly required, in order to add per hash bucket locks too :-). And hash bucket locking can even more improve performance. (We need the ordered locking of the buckets for both directions only when entries are added/deleted, otherwise a single read-lock of the given bucket is enough.)

Great, I'll go over it once more and will commit it to my tree.

I'll post a quick note once its committed so Pablo can rebase
his patches.

I've committed the patch and pushed it out.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux