Pablo Neira Ayuso wrote:
Hi Patrick,
A couple of minor issues related to this patch.
Patrick McHardy wrote:
+ hlist_nulls_del_rcu(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode);
Why is _rcu used? The lists are never used for a lookup.
There's no hlist_nulls_del() operation without rcu. I have a patch here
to add hlist_nulls_add_head() and hlist_nulls_del() although I guess
that you are going to tell me that you cannot apply that patch? So,
where to go?
Either way is fine I guess. Adding non _rcu function makes sense
I think (Eric CCed to correct me :)). But there's also no harm
in using the RCU functions as long as you add a comment stating
that you don't in fact rely on the RCU properties to avoid confusing
people.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
