Eric Leblond wrote:
Hi,
Le jeudi 19 mars 2009 à 10:45 +0100, Patrick McHardy a écrit :
Eric Leblond wrote:
This patchs adds support of modification of the used logger via sysctl.
...
By echoing "NONE" to a /proc/sys/net/netfilter/nf_log/PROTO file, the
logger corresponding to this PROTO is set to NULL.
...
+ if (write) {
+ if (!strnicmp(buffer, "NONE", *lenp - 1)) {
What is the motivation here for not doing a full comparison?
Suggested change: use strcmp
Hmmm that's correct. There is no motivation at all for insensitive
check. I should have done this.
The rest of the modifications are ok for me.
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
