Hi,
Le lundi 16 mars 2009 à 14:58 +0100, Patrick McHardy a écrit :
> Eric Leblond wrote:
> > +static int netfilter_log_sysctl_init(void)
> > +{
> > + int i;
> > +
> > + for (i = NFPROTO_UNSPEC; i < NFPROTO_NUMPROTO; i++) {
> > + char *pr_name = kmalloc(3, GFP_KERNEL);
>
> This needs to check for allocation errors.
>
> > + /* FIXME free at deinit but there is currently no deinit */
>
> And this needs to be fixed as well. If you want to simplify this, I'd
> suggest to just use static storage.
Thanks for your remarks and your patience, updated patch will follow
this mail.
BR,
--
Eric Leblond <eric@xxxxxx>
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=
