On Wednesday 2009-02-11 18:13, jamal wrote: >> >> Why move the struct now.. makes it harder to figure out what changed. >> So right, exit_error. > >Right (because of xtables_exittype) Ok, makes sense. (I guess git got in a dilemma and did not figure out the enum was moved ;-) >> > #define PROC_SYS_MODPROBE "/proc/sys/kernel/modprobe" >> > #endif >> > >> >-struct xtables_globals *xt_params; >> >+struct xtables_globals *xt_params = NULL; >> >> Do not initialize static members - this takes up extra space >> and adds no benefit. (zeroed anyway even in .bss) > >Ok. Do i need to regenerate the patch or send on top? As long as it's not applied, regen seems best. >> When is basic_exit_error invoked? In this patch alone, the users >> are missing (or the #define). > >tc/m_xt.c was at this point - but not any of the native iptables apps. >Later on patches iptables-xml uses the basic_exit_error() as well Ok. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
