On Wed, 2009-02-11 at 16:19 +0100, Jan Engelhardt wrote:
> On Tuesday 2009-02-10 04:29, jamal wrote:
> >
> >+struct xtables_globals
> >+{
> >+ unsigned int option_offset;
> >+ char *program_version;
> >+ char *program_name;
> >+ struct option *opts;
> >+ void (*exit_error)(enum xtables_exittype status, const char *msg, ...);
> >+};
> >+
>
> Why move the struct now.. makes it harder to figure out what changed.
> So right, exit_error.
Right (because of xtables_exittype)
> > #define PROC_SYS_MODPROBE "/proc/sys/kernel/modprobe"
> > #endif
> >
> >-struct xtables_globals *xt_params;
> >+struct xtables_globals *xt_params = NULL;
>
> Do not initialize static members - this takes up extra space
> and adds no benefit. (zeroed anyway even in .bss)
Ok. Do i need to regenerate the patch or send on top?
> When is basic_exit_error invoked? In this patch alone, the users
> are missing (or the #define).
tc/m_xt.c was at this point - but not any of the native iptables apps.
Later on patches iptables-xml uses the basic_exit_error() as well
cheers,
jamal
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
