Re: [PATCH 2/2 v3] New netfilter target to trigger LED devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 2009-02-11 12:38, Adam Nielsen wrote:
> +struct xt_led_info {
> +	char id[26];        /* Unique ID for this trigger in the LED class */
> +	__u32 delay;        /* Delay until LED is switched off after trigger */
> +	__u8 always_blink;  /* Blink even if the LED is already on */
> +
> +	void *internal_data; /* Kernel data used in the module */

I wonder. We talked about alignment and padding, but it seemed
to not have helped :)

This really needs
	void *internal_data __attribute__((aligned(8)))

And because 26+4+1 = 31, you can make that id[27] to fill-it-up.

Otherwise pretty clean.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux