Re: netfilter: half a patch for the pseudoregression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:

Here is the sample patch that fixes ip_tables_matches, but I still challenge the usefulness of /proc/net/ip_tables_* altogether. Those files should have been removed, or appropriately upgraded when revision support was introduced.

Thats not really the question right now since it exists and people
are using it. Feel free to start a discussion on removing it once
we've fixed the regression.

netfilter: make proc/net/ip_tables_matches print names from foreign NFPROTO

The ugliness this code adds could have been better spent at
a full and much more helpful dump.

This might get easier by simply using the same mutex for all families.
Not sure if its worth it, in any case not for now.

The patch looks fine, please resubmit when you have fixed the second
half with proper changelog (stating that it fixes a regression and
the commit introducing it).
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux