Matthew Helsley wrote:
On Wed, 2008-12-31 at 17:00 -0500, Matt Cross wrote:
I think the work to move ebtables to use xtables broke ebtables.
Specifically, in commit 8cc784eec6676b58e7f60419c88179aaa97bf71c the
return value of the match functions was inverted so that they return 1
(true) on matches instead of EBT_MATCH (0), and vice versa (look in
ebt_ip.c). The logic in ebtables.c (ebt_do_table() and
EBT_MATCH_ITERATE()) expect match functions to return 0 for matches.
The patch at the end of this message fixes the problem, but seems a
little hacky to me. Who's the right person to address this?
Jan, could you have a look at this please?
--- linux-2.6.28.orig/net/bridge/netfilter/ebtables.c 2008-12-24
18:26:37.000000000 -0500
+++ linux-2.6.28/net/bridge/netfilter/ebtables.c 2008-12-31
16:17:44.000000000 -0500
@@ -80,7 +80,7 @@
{
par->match = m->u.match;
par->matchinfo = m->data;
- return m->u.match->match(skb, par);
+ return !m->u.match->match(skb, par);
}
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
