Re: [PATCH 2/2 v2] New netfilter target to trigger LED devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+/*
+ * Known issues:
+ *
+ *  - It's possible to add multiple led triggers with the same name (as
+ *    set with --led-trigger-id)
+ *
+ */

So fix this?

I don't know how :-(  Since the LED hardware class doesn't (to my knowledge)
allow you to get a list of available LED triggers on the system, I'd have to
have some sort of global list that I append to every time a trigger is
created.  Given the likelihood of this happening (and the fact that it mostly
works having two triggers with the same name, it just looks bad) I didn't
think it was important enough for the additional code.

If this functionality is added to the LED class then I will happily update
my code to make use of it.

Not that it is overly important, but the comment style generally
seems to be (for multilines)
m{^(\s+)/\*\n(\1 \* \w+\n)+\1 \*/\n}

Will fix in the next revision.  I'm hoping to hear back from the "LED people"
before posting again as per Patrick's comment.

Cheers,
Adam.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux