Re: [PATCH 1/2 v2] New netfilter target to trigger LED devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ah bummer, I forgot about that.  Is this the best order?

No, that will break offsetof() in .userspacesize, as it will
become 0.

Oh, double bummer, I forgot about that also.

add id - 27 bytes.
add always_blink - 28 bytes.
28? That's good for alignment of a u32. Add delay.
32? That's good for alignment of a potentially-ptr64.

Ah okay, that works out quite well then.

And it's solved, even without thinking of NULs or prefixes.

Sorry, I thought you meant "please explain where the 26 comes from"

Just use [27] - the struct will be hardcoded forever,
and putting #defines somewhere gives a wrong illusion it might be changeable.

Will do.

Cheers,
Adam.

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux