Re: [PATCH 1/2 v2] New netfilter target to trigger LED devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 2008-11-11 12:31, Adam Nielsen wrote:
> +++ b/include/linux/netfilter/xt_LED.h
> @@ -0,0 +1,12 @@
> +#ifndef _XT_LED_H
> +#define _XT_LED_H
> +
> +struct xt_led_info {
> +	char id[26];        /* Unique ID for this trigger in the LED class */
> +	__u32 delay;        /* Delay until LED is switched off after trigger */
> +	__u8 always_blink;  /* Blink even if the LED is already on */
> +
> +	void *internal_data; /* Kernel data used in the module */
> +};

You now have an alignment problem, and need at least
	void *internal_data __attribute__((aligned(8)))
as explained in the PDF. Ultimatively, these shouls be reordered to
accomodate for gaps (see doc).

Also, why is it 26?
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux