Em Tue, Oct 07, 2008 at 09:36:24AM +0200, KOVACS Krisztian escreveu: > Hi, > > On Fri, 2008-10-03 at 10:47 -0300, Arnaldo Carvalho de Melo wrote: > > [...] > > > > Why don't you add it to __inet6_lookup, __inet6_lookup and the udp_lib > > > > lookup routines? And please rename it to skb_steal_sock, as it acts on a > > > > skb, not on a sock. > > > > > > Those functions don't have access to the skb so unless we change the > > > signature they won't be able to steal the reference. > > > > Indeed, but we should try to have the main TCP code flow clean, ditto for > > DCCP, free of such details, so after this activitity settles down I'll > > submit something like the patch below. > > > > If Dave agrees and you feel like merging it on your current patchset, > > feel free to do it. > > Ok, I'll pick this up. Didn't compile because of missing includes in > inet_hashtables.h but I've fixed it. > > -- > KOVACS Krisztian > > > inet_hashtables: Add inet_lookup_skb helpers > > To be able to use the cached socket reference in the skb during input > processing we add a new set of lookup functions that receive the skb on > their argument list. > > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> > Signed-off-by: KOVACS Krisztian <hidden@xxxxxxxxxx> Thanks a lot! - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
