From: KOVACS Krisztian <hidden@xxxxxxxxxx> Date: Wed, 01 Oct 2008 16:24:31 +0200 > Use the socket cached in the TPROXY target if it's present. > > Signed-off-by: KOVACS Krisztian <hidden@xxxxxxxxxx> Ok, this starts to get into controversial territory. :-) At the very least I think: 1) We should do this unconditionally, and even put a "unlikely" there in the test. 2) Actually, the whole operation belongs in a generic net/sock.h helper function, and this includes the leading if() test. In the resubmitted patch you can include both UDP and TCP and the change adding the generic helper all at once. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
