On Monday 2008-10-06 12:43, Patrick McHardy wrote: > > The patchset you've sent is missing the patch "fix one wrong return > value" from your tree. > > Please send that one seperately. > Oh joy of git-format-patch <NOT_SO_INCLUSIVE_SHA>..HEAD! Here's PATCH "-01/23": === commit 9ea25486b5c9b3aed90525721fe598397a5e2581 Author: Jan Engelhardt <jengelh@xxxxxxxxxx> Date: Sun Oct 5 11:26:51 2008 -0400 netfilter: ebtables: fix one wrong return value Usually -EINVAL is used when checkentry fails (see *_tables). Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx> --- net/bridge/netfilter/ebtables.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index 340e1c6..942739d 100644 --- a/net/bridge/netfilter/ebtables.c +++ b/net/bridge/netfilter/ebtables.c @@ -756,7 +756,7 @@ ebt_check_entry(struct ebt_entry *e, struct ebt_table_info *newinfo, } else if (t->u.target->checkentry && !t->u.target->checkentry(name, e, NULL, t->data, hookmask)) { module_put(t->u.target->me); - ret = -EFAULT; + ret = -EINVAL; goto cleanup_watchers; } (*cnt)++; -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html