Re: [ULOGD2 PATCH 1/4] Make NFLOG export raw header and source raw address.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Thursday, 2008 July 24 at  9:25:24 +0200, Pablo Neira Ayuso wrote:
> Eric Leblond wrote:
> > diff --git a/configure.in b/configure.in
> > index 8e0f6a3..c25bbdb 100644
> > --- a/configure.in
> > +++ b/configure.in
> > @@ -41,8 +41,10 @@ PKG_CHECK_MODULES(LIBNFNETLINK, libnfnetlink >= $LIBNFNETLINK_REQUIRED,, AC_MSG_
> >  
> >  PKG_CHECK_MODULES(LIBNETFILTER_CONNTRACK, libnetfilter_conntrack >= $LIBNETFILTER_CONNTRACK_REQUIRED,, AC_MSG_ERROR(Cannot find libnetfilter_conntrack >= $LIBNETFILTER_CONNTRACK_REQUIRED))
> >  
> > -PKG_CHECK_MODULES(LIBNETFILTER_LOG, libnetfilter_log >= $LIBNETFILTER_LOG_REQUIRED,, AC_MSG_ERROR(Cannot find libnetfilter_log >= $LIBNETFILTER_LOG_REQUIRED))
> > +PKG_CHECK_MODULES(LIBNETFILTER_LOG, libnetfilter_log >= $LIBNETFILTER_LOG_REQUIRED,, AC_MSG_NOTICE(Cannot find libnetfilter_log >= $LIBNETFILTER_LOG_REQUIRED))
> >  
> > +AC_CHECK_LIB([netfilter_log],[nflog_get_msg_packet_hwhdrlen],
> > +                        AC_DEFINE_UNQUOTED([HAVE_NFLOG_RAWHEADER],[1],[NFLOG userspace has raw header support]),,[-lnfnetlink])
> 
> You know my policy on this. I'm not willing to pollute the source code
> with #ifdef's, I prefer bumping the libnetfilter_log version dependency
> checking. At least during the development stage, later we can discuss
> this issue again.

Yes, I know that but I had to try ;)

> 
> >  CT_CHECK_POSTGRES_DB()
> >  AM_CONDITIONAL(HAVE_PGSQL, test "x$PQLIBPATH" != "x")
> > diff --git a/input/packet/ulogd_inppkt_NFLOG.c b/input/packet/ulogd_inppkt_NFLOG.c
> > index cb58661..c2de88c 100644
> > --- a/input/packet/ulogd_inppkt_NFLOG.c
> > +++ b/input/packet/ulogd_inppkt_NFLOG.c
> > @@ -9,6 +9,8 @@
> >  #include <errno.h>
> >  
> >  #include <ulogd/ulogd.h>
> > +#include <config.h>
> 
> Where's config.h?

config.h.in is automayically generated by autoheader (during call to autogen.sh)
and is converted to config.h by configure script.

> I have enqueued the following patch until I can apply 2, 3 and 4. Also,
> I have a attached a minor cleanup to break lines at 80 chars.

Ok, I will rework some point of the patchset.

BR,
-- 
Eric Leblond
INL: http://www.inl.fr/
NuFW: http://www.nufw.org/
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux