Eric Leblond wrote:
Hello,
On Wednesday, 2008 July 9 at 23:18:30 +0200, Patrick McHardy wrote:
Eric Leblond wrote:
I think the proposed patch is a best effort work. It should be enough
for most users as ethernet headers are the more common. But I agree, we
can't have a full working solution with ULOG.
I will try to find some time to rework my NFLOG patch to see if it is
possible to cleanly send the source and destination hardware address to
userspace via NFLOG.
I don't see any other mean but to get hardware address from device and
not from skb. I really don't like it, as this can be done from userspace
directly. I will thus stop working on adding destination address to
NFLOG messages.
IMHO, this patch is not harmfull and will help some people. It may worth
to be push in the git tree.
+ ulogd_log(ULOGD_DEBUG, "Unknown mac_len (%d), "
+ "rejecting packet", pkt->mac_len);
This comment made me believe that it would break header
printing for non-ethernet packets. If that is not true,
I have no objections.
Hmm, you're right but user using non-ethernet packets can upgrade to
NFLOG ;)
I assume thats not meant seriously :) But we should integrate
new features into the new things, not break old things and
expect users to upgrade :)
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
