Pablo Neira Ayuso wrote:
Patrick McHardy wrote:
Pablo Neira Ayuso wrote:
Eric Leblond wrote:
This patch introduces a parsing of the hardware header field based on
the length of the field. It currently only detects ethernet header and
fill mac.saddr and mac.daddr properly.
With this behaviour it may be impossible to support all kind of devices
but ULOG will soon be deprecated in favor of NFLOG.
Since we do not have more information in ULOG, I see this as a best try
to detect what kind of layer 2 header is there. The other choice is not
to include layer 2 information at all if we use ulog as input which also
seems reasonable to me. If users want new features they have to migrate
from ulog to nflog IMO.
I'm willing to finish the compatibility layer in libnetfilter_queue,
this could probably help to deprecate it.
If Patrick does not have any objection, I'll apply this and the previous
layer 2 related patches.
One objection:
+static int parse_macheader(struct ulogd_key *ret, ulog_packet_msg_t
*pkt,
+ )
+{
+ int hwlen;
+
+ switch (pkt->mac_len) {
+ case (2 * ETH_ALEN +2):
+ hwlen = ETH_ALEN;
+ break;
+ default:
+ ulogd_log(ULOGD_DEBUG, "Unknown mac_len (%d), "
+ "rejecting packet", pkt->mac_len);
+ ret[ULOG_KEY_OOB_PROTOCOL].u.value.ui16 = 0;
+ ret[ULOG_KEY_OOB_PROTOCOL].flags |= ULOGD_RETF_VALID;
+ return ULOGD_IRET_OK;
This appears to be breaking logging for anything but ethernet
packets. We can't do that, especially since ulogd1 has long
been in maintenance-only mode.
Hm, this patch applies to ulogd2, probably you got confused with the
subject?
Indeed, I mixed that up.
But indeed, I agree with you. Eric, I think that it's better to drop any
effort in trying to add layer 2 support for ulogd2 if the user use ULOG
as input logger. If users want new features, eg. the layer 2 information
in their log messages, they should upgrade to NFLOG.
Agreed, I really don't see how this can be done without breaking
things. The necessary information is not present in the ULOG
messages.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
