Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Engelhardt wrote:
On Wednesday 2008-07-02 15:51, Patrick McHardy wrote:
Seems you're the first to try module_param_named with a bool :)
Does this help?
It helps but produces a lot of warnings in other places:

kernel/printk.c: In function '__check_time':
kernel/printk.c:570: warning: return from incompatible pointer type
Ah I see. You're supposed to use an int for the variable and
bool only for module_param_named.

Yes but since we have 'bool' type (though only since recently),
module_param_bool should also *take* a bool.

It probably should, but module_param preceds the boolean type
in the kernel, so it seems someone wasn't motivated enough to
fix up all the users.

And since this is not related to netfilter in any way, lets
just use it how its supposed to.


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux