Re: [PATCH 2/2] Netfilter: Accounting rework: ct_extend + 64bit counters (v3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Wed, 2 Jul 2008, Patrick McHardy wrote:

Krzysztof Oledzki wrote:


On Tue, 24 Jun 2008, Krzysztof Oledzki wrote:

<CUT>

+static unsigned int nf_ct_acct __read_mostly = NF_CT_ACCT_DEFAULT;

Perhaps this should be bool instead?

Yep.

It seems that it has to stay as unsigned int - if I change it to bool I get:
 net/netfilter/nf_conntrack_acct.c: In function '__check_acct':
net/netfilter/nf_conntrack_acct.c:27: warning: return from incompatible pointer type

You also need to use the proper module_param type.

Other than:
 module_param_named(acct, nf_ct_acct, bool, 0644);
?

Best regards,

				Krzysztof Olędzki

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux