Tseng, Kuo-Lang wrote on Thursday, April 10, 2008 1:23 PM: > Patrick McHardy wrote on Tuesday, April 08, 2008 10:38 AM: >> >> >> I wanted to apply this, but the patch has multiple checkpatch >> errors. There are also some codingstyle errors checkpatch doesn't >> complain about, like: >> >> + for (i = 0; i < 4; i++) >> + tmp_addr.in6_u.u6_addr32[i] = >> ih6->saddr.in6_u.u6_addr32[i] & ^^^ needs tab >> >> It also seems the TCP/UDP/.. logging part could be shared between >> IPv4 and IPv6. The protocol checks seem to be missing UDPLITE. >> >> Please fix those up and resend, thanks. > > I'll fix and re-send the patch next week. Hi, Please try out the updated patch. It has fixed the coding style errors and added protocol checks for UDPLITE, and shared the TCP/UDP/.. logging part.
Attachment:
br-nf.patch
Description: br-nf.patch