RE: [Ebtables-devel] [PATCH 2/2] Add IPv6 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Patrick McHardy wrote on Tuesday, April 08, 2008 10:38 AM:
> 
> 
> I wanted to apply this, but the patch has multiple checkpatch
> errors. There are also some codingstyle errors checkpatch doesn't
> complain about, like:
> 
> +       for (i = 0; i < 4; i++)
> +          tmp_addr.in6_u.u6_addr32[i] =
>          ih6->saddr.in6_u.u6_addr32[i] & ^^^ needs tab
> 
> It also seems the TCP/UDP/.. logging part could be shared between
> IPv4 and IPv6. The protocol checks seem to be missing UDPLITE.
> 
> Please fix those up and resend, thanks.

I'll fix and re-send the patch next week. 
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Netfitler Users]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux