From: Ivo van Doorn <ivdoorn@xxxxxxxxx> Date: Sun, 20 Apr 2008 11:31:00 +0200 > Not sure about it, but doesn't LEDS_CLASS depend on NEW_LEDS ? > Which would make selecting LEDS_CLASS broken when NEW_LEDS isn't enabled? True, what an awful dependency chain. NEW_LEDS requires HAS_IOMEM. This is to handle platforms like S390 and UM. But I think this protection is overboard. Specific drivers might need IOMEM functionality, but the basic infrastructure does not. All of the core infrastrucure and generic LEDS facilities, including NEW_LEDS, LEDS_CLASS, and LEDS_TRIGGERS, don't need the IOMEM protection. And neither do the LED device drivers, they already each have a depenency for a specific platform. You could even imagine a hypervisor based LED driver that a platform like S390, which does not enable HAS_IOMEM, might want to support under this infrastructure. I think NEW_LEDS can be completely eliminated. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
